feat: windows node set mcr containerd host config for network isolated cluster#7902
Merged
feat: windows node set mcr containerd host config for network isolated cluster#7902
Conversation
fseldow
requested review from
AbelHu,
Devinwong,
awesomenix,
cameronmeissner,
djsly,
ganeshkumarashok,
juan-lee,
junjiezhang1997,
lilypan26,
mxj220,
pdamianov-dev,
phealy,
r2k1,
timmy-wright and
zachary-bailey
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds Windows node support for network isolated clusters by configuring containerd to use a bootstrap profile container registry as a mirror for MCR (Microsoft Container Registry) images. The implementation adds a new PowerShell function for Windows nodes and includes corresponding variable initialization in the CSE scripts. Additionally, it fixes a missing "server" directive in the Linux MCR China Cloud configuration.
Changes:
- Adds Windows containerd configuration to redirect MCR image pulls to the bootstrap profile container registry for network isolated clusters
- Sets global variables for bootstrap profile registry and MCR repository base in Windows CSE scripts
- Fixes missing "server" directive in Linux MCR China Cloud containerd hosts configuration
- Adds e2e test to validate Windows containerd registry configuration in network isolated clusters
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| staging/cse/windows/containerdfunc.ps1 | Adds Set-BootstrapProfileRegistryContainerdHost function and conditional logic to configure MCR registry mirroring for network isolated clusters |
| parts/windows/kuberneteswindowssetup.ps1 | Initializes global variables for bootstrap profile container registry server and MCR repository base |
| parts/linux/cloud-init/artifacts/cse_config.sh | Adds missing "server" directive to MCR China Cloud containerd hosts configuration |
| e2e/scenario_win_test.go | Adds test for Windows network isolated cluster containerd configuration |
fseldow
force-pushed
the
xinhl/windowsimage
branch
from
336ab5b to
df935a2
Compare
fseldow
force-pushed
the
xinhl/windowsimage
branch
from
23ca783 to
00d05b0
Compare
timmy-wright
reviewed
Mar 2, 2026
timmy-wright
approved these changes
Mar 2, 2026
timmy-wright
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
To support network isolated cluster
setup mcr containerd hosts, to allow the cluster pull mcr images from acr first.
feat: windows node set mcr containerd host config for network isolated cluster
Which issue(s) this PR fixes:
Fixes #